test: validate materialized MCP corruption fixtures#163
Merged
ProfRandom92 merged 2 commits intoMay 21, 2026
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new test suite, tests/test_mcp_trace_corruption_validation.py, which validates the integrity and structural correctness of MCP trace corruption fixtures. The tests ensure that corruption operators like DROP_APPROVAL_GATE, REMOVE_DEPENDENCY_EDGE, and TRUNCATE_RECOVERY_PATH are correctly applied to source fixtures while maintaining the consistency of non-target files. Review feedback focuses on improving the robustness of JSON loading and data processing by replacing assertions with explicit error handling and adding type guards to prevent potential crashes on malformed input data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changed files:
Testing:
pytest -q tests/test_mcp_trace_corruption_validation.pyand observed4 passed.npm run checkwhich executedpytestand the project checks and completed successfully (304 passedoverall as part of the run).Risks:
Next:
Codex Task